Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLog encryption prototype #183

Merged
merged 2 commits into from
May 30, 2024
Merged

XLog encryption prototype #183

merged 2 commits into from
May 30, 2024

Conversation

dAdAbird
Copy link
Member

Encrypts XLog pages while writing them to the segment file.
This is just a POC without any proper key management.

@dAdAbird dAdAbird requested review from dutow and codeforall and removed request for dutow April 24, 2024 17:24
@dAdAbird dAdAbird force-pushed the xlog_smgr_poc branch 3 times, most recently from 036f4eb to 912eb2e Compare April 29, 2024 14:26
Encrypt/decrypt whole Pages while pwrite/pread
see TODOs in the code

Use proper IV and counter

Use shmem for the encrypt buffer

Handle streaming replication

Update PG patch

Remove pg.patch

remove rubbish
Copy link
Contributor

@codeforall codeforall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to discuss the test case failures separately. Otherwise, the code changes look good.

@dAdAbird dAdAbird merged commit 8973619 into percona:smgr May 30, 2024
0 of 8 checks passed
@dAdAbird dAdAbird deleted the xlog_smgr_poc branch May 30, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants