Remove 'percona_tde.pg_tde_key_provider' user catalog #230
Conversation
…rovider info file for key providers This commit removes the 'percona_tde.pg_tde_key_provider' user catalog and replaces it with a provider info file for saving key providers. This change ensures that the key provider information can be accessed during recovery, as the user catalogs cannot be relied upon in such scenarios. The commit maintains the current API functions, so callers will not experience any differences in functionality or usage after this change. Additionally, the commit adjusts how the shared memory manager retrieves information about the number of LWLocks required by the extension, optimizing the process. TODO: Implement xlog message for cleaning up the provider info file during recovery operations to ensure consistency and avoid potential issues.
| EXECUTE FUNCTION keyring_delete_dependency_check_trigger(); | ||
|
|
||
| -- Key Provider Management | ||
|
|
||
| CREATE OR REPLACE FUNCTION pg_tde_add_key_provider(provider_type VARCHAR(10), provider_name VARCHAR(128), options JSON) |
There was a problem hiding this comment.
Should we also have pg_tde_remove_key_provider() and/or pg_tde_edit_key_provider()? And also pg_tde_list_key_providers(), since there is no way to check what providers are there
Plus, since we ain't restricted with the db access anymore, it make sense to have ability to set a "global" key provider which applies to all dbs by default by can be redefined to a db-local one. It needs thoughts around security restrictions. But met be convenient for clusters with multiple dbs. It's definitely not for now, just thoughts out loud.
There was a problem hiding this comment.
I think it's a good idea. We can take it up as a separate PR.
src/catalog/tde_keyring.c
Outdated
|
|
||
| void InitializeKeyProviderInfo(void) | ||
| { | ||
| ereport(LOG, (errmsg("Initializing TDE principal key info"))); |
There was a problem hiding this comment.
Here and in many places - in the backend code (and in most of our code) ereport/elog error messages never start with capitalized letter if it is not an abbr. (like CPU, SQL etc) or all caps word. Let's be consistent with the style
There was a problem hiding this comment.
Fixed for all messages added as part of this PR!
We might also need to do a code run-through and fix similar inconsistencies in other parts of the code.
| -- Note: The table is created using heap storage becasue we do not want this table | ||
| -- to be encrypted by pg_tde. This table is used to store key provider information | ||
| -- and we do not want to encrypt this table using pg_tde. | ||
| CREATE TABLE percona_tde.pg_tde_key_provider(provider_id SERIAL, |
There was a problem hiding this comment.
Shouldn't we replace this with a view that provides the same functionality?
There was a problem hiding this comment.
I believe we would need to provide a view and edit function as mentioned in the comment #230 (comment), but we can handle it as a separate PR
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Refactor log/error messages and variable names; fix memory leak in get_keyring_infofile_path function
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Remove 'percona_tde.pg_tde_key_provider' user catalog and introduce provider info file for key providers
This commit removes the 'percona_tde.pg_tde_key_provider' user catalog and replaces it with a provider info file for saving key providers. This change ensures that the key provider information can be accessed during recovery, as the user catalogs cannot be relied upon in such scenarios.
The commit maintains the current API functions, so callers will not experience any differences in functionality or usage after this change.
Additionally, the commit adjusts how the shared memory manager retrieves information about the number of LWLocks required by the extension, optimizing the process.
TODO: Implement xlog message for cleaning up the provider info file during recovery operations to ensure consistency and avoid potential issues.