Fix smgr for PG17 #263
Merged
Fix smgr for PG17 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dAdAbird
commented
Aug 20, 2024
src16/smgr/pg_tde_smgr.c
Outdated
| @@ -0,0 +1,218 @@ | |||
|
|
|||
There was a problem hiding this comment.
@dutow, @codeforall I'm not sure if need this back port for PG16. Do we?
There was a problem hiding this comment.
we probably do need it at least for tests
There was a problem hiding this comment.
No need for it, the smgr atch is PG17 only, this shouldn't be in the src16 folder.
dAdAbird
force-pushed
the
smgr_registersync
branch
from
0261f22 to
33403a7
Compare
dutow
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG_17_STABLE added new method to "f_sgmr" interface. That method was lacking in our tde_smgr which led to SIGSEGV when core tried to use it.