PMM-1035 Fix toast slice fetching with offset #282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PG-1035
PG
strings
regression tests failed on section when it checks how substirng func works for toastedbytea
data: https://github.com/postgres/postgres/blob/master/src/test/regress/sql/strings.sql#L575-L606It seems that reason for that was that
start_offset
was calculated improperly. Looks likePG_TDE_DECRYPT_DATA
should getstart_offset
alligned by chunk size, but when we copy data to result we can and should applysliceoffcet
.