Move AcquisitionReport work into asynch thread #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR takes a change that was made for deployment (see this commit) and merges it into the overall repo. Specifically, this change makes AcquisitionReport asynchronous; it will always return success to the web app, and will actually perform the online learning update in an asynchronous thread. This means that the web app no longer has to wait for the policy update to succeed, which could take longer depending on the number of trainable parameters.
Testing procedure
lovelace
(e.g., the web app succesfully invokes an acquisition report, without blocking, and the data gets saved)Before opening a pull request
pre-commit run --all-files
pylint --recursive=y --rcfile=.pylintrc .
. All warnings butfixme
must be addressed.Before Merging
Squash & Merge