Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AcquisitionReport work into asynch thread #210

Open
wants to merge 1 commit into
base: ros2-devel
Choose a base branch
from

Conversation

amalnanavati
Copy link
Contributor

Description

This PR takes a change that was made for deployment (see this commit) and merges it into the overall repo. Specifically, this change makes AcquisitionReport asynchronous; it will always return success to the web app, and will actually perform the online learning update in an asynchronous thread. This means that the web app no longer has to wait for the policy update to succeed, which could take longer depending on the number of trainable parameters.

Testing procedure

  • Tested via the home deployment.
  • In addition, before merging in, we should verify that it works on lovelace (e.g., the web app succesfully invokes an acquisition report, without blocking, and the data gets saved)

Before opening a pull request

  • pre-commit run --all-files
  • Run your code through pylint. pylint --recursive=y --rcfile=.pylintrc .. All warnings but fixme must be addressed.

Before Merging

  • Squash & Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant