fix(ObjectDescriptionFactory): swap function_exists with enum_exists #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function_exists() function should be used first, so that the composer autoloader doesn't try to include an already included file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
function_exists()function should be used first, so that theenum_exists()doesn't cause the composer autoloader to try to include a file that has already been included.Basically, it is composer who should fix this, but they have decided it works fine.
To reproduce:
use function Psl\Str\Byte\pad_leftin\Appnamespace.\Appas target, for example:arch()->expect('App')->not->toImplement(Throwable::class)Result: PHP Fatal error: Cannot redeclare Psl\Str\Byte\pad_left()