-
Notifications
You must be signed in to change notification settings - Fork 0
Minutes
Bronson Quick edited this page Jan 29, 2014
·
17 revisions
This is summary of Hangouts and discussions for reference any points of discussion for the next catch up can be added here.
- Bronson experimented with add_theme_support for html-tidy and bem support.
- Bronson introduced two new theme [include files] (https://github.com/peterwilsoncc/collaborate/commit/63544c255ce98d5d06ab323deab315124eefb568#diff-31b84d5a3c18136b46d07be2047381aeR151) which will contain our filters and actions to address two of our outstanding issues.
- Bronson removed some unnecessary globals in our body_class function and was corrected by Pete about an incorrect refactor of the body_class filter so Bronson added that back.
- Pete updated and recompiled Inuit
- Pete introduce left and right padding to the Inuit grid because as we discussed last time. This is more like an industry standard grid.
- Bronson will introduce more pluggable functions for
collaborate-html-tidyandcollaborate-bemfrom Pete's Floating Giant theme - Pete will think about CSS classes.
- Pete merged in the loop.
- Pete added back comments to pages.
- Inuit, Pure(with a mod for offsets and mobile first)and Unsemantic grids were discussed.
- Inuit is the winner however there is one caveat which is the grids only having padding-left. We'll attempt to half that and add padding-right and also adjust the negative margin-left on the .grid class.
- Inuit also isn't designed to be mobile first so we might modify that later.
- For the next meeting we'll be adding in the Theme Unit Test Data and listing out the filters we will need to use to clean up the html & CSS and add issues in Github so we can start working through them and cleaning them up. These will include things like galleries, images and pagination etc.
- After the grid is in we'd like to have a PSD of the new grid to give to designers.
- Pete will check IDs in crane
- Changed all the cool cats to something sensible
- Add back comments on pages with the intention of them being removed when we get to the "html tidy" functionality
- Post formats - None to start with but will incrementally add them in minor release in the future
- Push and Pull classes to Pete's grid. 2 or 3 breakpoints? Inuit/Unsemantic/Pete's grid/Pure/Grid Pack
- Merge Crane JS and the loop
- Add append, prepend and remove to [Query] (https://github.com/peterwilsoncc/query). To get some basic documentation.
- Talked about an implentation of https://gist.github.com/peterwilsoncc/6291028 for actions and filters in JavaScript for Collaborate.
- Pete to work on Query
- Bronson to work on the loop
- discuss HTML in pull #2(closed).
- discuss minor tweaks in html by BQ More robustness
- discuss @peterwilsoncc's file structure. e.g. assets/child/ in a parent theme
- JavaScript shell (refer pw;js-base branch)
- Singletons (refer pw;php-classes branch, which Peter's not entirely convinced about)
- Grunt demo
###Actions
- discuss HTML in pull #2(closed) - Approved
- discuss minor tweaks in html by BQ More robustness - Approved
- discuss @peterwilsoncc's file structure. e.g. assets/child/ in a parent theme. - Copying these files from the parent into a child theme doesn't feel like an ideal solution as it's not the WordPress way. We definitely don't want to do an @import in a child theme either because it's bloated. We'd like to explore importing Sass partials from the partent theme into a child theme that compile into a style.css. We could request _normalize.scss, _typography.scss from the parent any nothing else. Bronson will explore if there is something like if_file_exists solution in Sass or Grunt.
- JavaScript shell (refer pw;js-base branch) - We had a good discussion about this item. jQuery can be bloated depending on the use case. We're thinking that we might enqueue Sizzle in our theme (depending on the namespacing as it might clash with WP's jQuery) as it's a speedy selector engine and if we want to make this 'designer' friendly then they won't use most of the power of jQuery. We'll also have an easy option to remove this when themes need to use ajax functions in jQuery and other awesomeness.
- Singletons (refer pw;php-classes branch, which Peter's not entirely convinced about) - We're ditching this and going with if ( ! function_exists ( 'rad' ) to reduce the barrier to entry for designers'
- Grunt demo - Peter got a small preview of Grunt's power. Once the theme is finalised Bronson will add more command line prompts to ask about which files should be added or deleted from the base theme which will help to automate workflow and increase consistency in both our agencies.
####Other items
- Bootstrap 3's grid structure is more ideal than Inuit's. 4 breakpoint variables is better than Inuit's.
- Inuit has some lovely helpers that aren’t in Compass and will be either included or forked. Objects
- wireframes
- html5 semantics
- BEM
- PW add inuit.css submodule
- BQ use class in functions.php - how to override and avoid all the useless exposure functions in bigred/rapid.
- PW HTML structure without loop
- Initial kickoff meeting.
- A general discussion regarding the goals and technologies for the Collaborate WordPress starter theme.
- The majority of the points of discussion from this hangout were added to the repositorys README.md.