Add support for Pip 23.3.1. #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required updating the locker parsing to account for differences in 23.3.x log output. Although 23.3 has significant changes from 23.2.x, I was away during its release and no one clamored for it; so I'm just moving ahead to the small 23.3.1 update.
huonw
approved these changes
Nov 4, 2023
This was referenced Jun 7, 2024
jsirois
added a commit
that referenced
this pull request
Jun 8, 2024
When support for Pip 23.3.1 was added in #2276 a latent bug in artifact URL recording was exposed in cases where the index being used issued re-directs. Fix up artifact URL recording to grab the primary index URL and not subsequent re-directs. Implementing the fix above led to a test failure that revealed another bug whereby lock file artifact downloads were not respecting the locked resolve target when it was a foreign platform, which is now fixed. Finally, fixing the un-patched foreign platform target issue in lock file artifact downloads revealed that artifact URLs with hashes were not being taken advantage of in all cases. Now, when there is a version of an artifact URL seen that contains hashes - the best of those is always used to prevent needless post-processing to download and hash the artifact at lock creation time. Fixes #2414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required updating the locker parsing to account for differences in
23.3.x log output.
Although 23.3 has significant changes from 23.2.x, I was away during its
release and no one clamored for it; so I'm just moving ahead to the
small 23.3.1 update. The changelogs are here: