New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect regex for PEX_PYTHON precision warning #2622

Merged

jsirois merged 1 commit into pex-tool:main from tgolsson:ts/spurious-warning-pex-python

Dec 12, 2024

Contributor

tgolsson commented Dec 12, 2024

Looks like this + is misplaced, as it means PEX_PYTHON=3.+ would be accepted but it rejects and warns for PEX_PYTHON=python3.11.

Leads to this funky warning message telling us to use the setting we already have :)

PEXWarning: Using a venv selected by PEX_PYTHON=python3.11 for <snip>.pex at  ...
To avoid this warning, either specify a Python binary with major and minor version
in its name, like PEX_PYTHON=python3.11 or ...


          fix regex plus placement

a42c12f

tgolsson changed the title ~~fix regex plus placement~~ Incorrect regex for PEX_PYTHON precision warning

tgolsson changed the title ~~Incorrect regex for PEX_PYTHON precision warning~~ Fix incorrect regex for PEX_PYTHON precision warning

jsirois approved these changes

View reviewed changes

Member

jsirois left a comment

Thanks Tom. I'll get a release out later today.

jsirois merged commit 74f34aa into pex-tool:main

23 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet