Snapshot submission: Streamling wording for success message #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts the recently changed compact snapshot information to be closer to what it was before, and adds "full" to the full snapshot message for clarity: I [default] Submitted compact snapshots successfully: 5 activity, 2 logs I [default] Submitted full snapshot successfully Note that the compact snapshot message continues to emitted once per minute, not continuously as in past releases.
keiko713
approved these changes
Nov 29, 2023
msakrejda
approved these changes
Nov 29, 2023
msakrejda
added a commit
to pganalyze/pganalyze-docs
that referenced
this pull request
Nov 29, 2023
|
Since there are no strong opinions either way, I'll go ahead and merge this - I think it feels slightly better to me to be consistent here (and I've wished for a better way to search for "full snapshot" in the logs previously, so that helps with that too). |
msakrejda
added a commit
to pganalyze/pganalyze-docs
that referenced
this pull request
Nov 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the recently changed compact snapshot information to be closer to what it was before, and adds "full" to the full snapshot message for clarity:
Note that the compact snapshot message continues to emitted once per minute, not continuously as in past releases.