Support tracestate query tag with marginalia shape #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
msakrejda
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
So technically : is a valid URL component value and so it does not need to be percent-encoded, so as far as I can tell from sqlcommenter docs, it could occur unescaped in the name of a key. However, I think it's both unlikely to be there in the first place, and, if present, it's likely that it will be percent-encoded (since even values that don't have to be encoded can be encoded, and, e.g., the node/browser encodeURIComponent does encode it). So I think this is fine as is.
Co-authored-by: Maciek Sakrejda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was testing, I realized that tracestate is not propagating well when it's passed with marginalia shape.
This PR should fix it.
Honestly, I'm not 100% sure if "With sqlcommenter format (key='value'), key shouldn't include ":"" is accurate, but I think it's a safe assumption to make.
With sqlcommenter, the tracestate might be URL escaped, but let's assume that it's not for marginalia here.