Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitations/fasterq #5

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Limitations/fasterq #5

merged 3 commits into from
Jan 25, 2024

Conversation

apetkau
Copy link
Member

@apetkau apetkau commented Jan 25, 2024

Adds parameter --max_jobs_with_network_connections to limit the number of parallel downloads (in the prefetch step) from NCBI.

Changed reads directory from results/sratools/reads to results/reads.

Copy link

github-actions bot commented Jan 25, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 429470c

+| ✅ 118 tests passed       |+
#| ❔  28 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • schema_lint - Schema $id should be https://raw.githubusercontent.com/phac-nml/fetchdatairidanext/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/phac-nml/fetchdatairidanext/main/nextflow_schema.json

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-fetchdatairidanext_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-fetchdatairidanext_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-fetchdatairidanext_logo_dark.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-fetchdatairidanext_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-fetchdatairidanext_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-fetchdatairidanext_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchdatairidanext/fetchdatairidanext/.github/workflows/awstest.yml
  • actions_awsfulltest - actions_awsfulltest
  • pipeline_name_conventions - pipeline_name_conventions

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-25 22:22:29

@apetkau apetkau merged commit 8131a08 into dev Jan 25, 2024
6 checks passed
@apetkau apetkau deleted the limitations/fasterq branch January 25, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant