Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug: AUC start 0 (which also needs Feature: C0 imputation) (#138)
* bug: force doses times to be AFRLT.dose (at ARRLT = 0) * data: correct PKROUTE -> ROUTE * enhancement: create function to create impute_c0 column * enhancement: include additional C0 imputation strategies * feature: intervals include imputate strategy with duplicated rows apart for non-c0 parameters * bug: PKNCAconc formula adapted for PKNCA to consider predoses for impute_predose * bug: solved classification of doses in create_c0_impute * bug: perfectionated formulas to consider different analytes appropiately * style: solve most lintr issues * refactor: delete report files that should not have been called * refactor: nolint in customized PKNCA_impute_method functions * wordlist: add PKNCA_impute_method functions * documentation: functions in R/PKNCA_impute_method_additions.R * feature: c0 input & when no checked use as interval start 1st observation * bug: solved PKNCA warnings "No concentration data" * bug: solved issue of duplicated tmax in results * refactor: NCA results with all dose and conc columns first * bug: fixed impute_method_start_c1 unneded argument issue * refactor: delete unused functions in reshape * refactor: input selectors for analyte and dosno put together in UI and renamed (select_X) * refactor: change strategy for input of AUC intervals * bug: fixed new intervals strategy and align with PKNCA running * revert feat: back to old UI function for AUC intervals * fix: interval default start since dose, aucint for manual intervals, adjust reshape for it * fix: when C0 is not imputed, start is at C1 * lintr: code cleaning * fix: issue in slope_selector with new name for input$cyclenca * refactor: make own function to create intervals with dose data * fix: adapt lambda_slope_plot to use type_interval column instead of end==Inf * fix: adapt create_c0_impute_column to not use artificial time_dose column * fix bug: correct call for mydata$dose instead of mydose * fix: solve issues when C0 is not imputed to start at C1 * lintr: lint_dir cleaning * fix oldrel: deleted line used for testing * fix: update roxygen2 documentation for format_data.R functions * fix: spellcheck added words to WORDLIST * fix: roxygen2 for missing documetnation PKNCA_impute_method_additions.R * fix: solved issue app crashes with auc rule sets * fix: created pknca_trigger to run slope_selector when apply/save changes * refactor: data selection tab with arranged dataset by subject * aesthetics: add hovering message and new label in checkbox C0 imputations * fix: lintr, roxygen doc and clast added to default params in NCA * fix: reporting all parameters instead of just auc related for intervals * documentation: roxygen update * fix: delete partial_auc_input.R from R/ folder and leave in inst/shiny/functions * fix: add tests and prevent input errors in format_data.R functions * fix: issue with select_analyte after merge * test: add tests for PKNCA_impute_method_additions.R and prevent NA in start_log * refactor: create_c0_impute testing, column preventions and renaming (create_start_impute) * fix: lintr code cleaning and roxygen documentation * fix: update description and wordlist * fix: impossible test deleted and improved results column order display * style: add details to function description and rename PKNCA_impute_method_start_log(slope) * style: time == start & link on PKNCA custom function guidelines * test: modify tests from expect_s3_class to expect_no_error for nested functions * style: delete unnecessary variable assignment in function * documentation: update roxygen2 * fix: filtering later and using dose.time + arrlt for non-t0 solves partially problem * data: corect ADOSEDUR (ADOSEDUR<0 turned into |ADOSEDUR|) * data: adapt USUBJID=11102, DOSNO=9 to a reasonable dose time (AFRLT-ARRLT = 1680.5) adnca2 %>% mutate(AFRLT = ifelse(DOSNO==9 & USUBJID==11102, AFRLT + 168, AFRLT), NFRLT = ifelse(DOSNO==9 & USUBJID==11102, NFRLT + 168, NFRLT) ) * fix: solve issue with end<start due to incorrect create_dose rows output * refactor: lintr code cleaning * style: apply suggestions from m-kolomanski Co-authored-by: Mateusz Kołomański <[email protected]> * style: drug_column call instead of hardcoded "DRUG" in create_start_impute.R * style: lintr code cleaning * style: improve conditional syntax in create_start_impute.R * style issue: clean computation of pk.calc.c0 logslope * style: suggestions from code review m-kolomanski Co-authored-by: Mateusz Kołomański <[email protected]> * nitpick: solve nitpicks pointed out by m-kolomanski * refactor: rename reshape_PKNCA_results to pivot_wider_pknca_results * refactor: change the names of format_data.R functions and update documentation * fix: format_pkncadose_data includes either DOSNO or TIME (dose time) to slice data. route_column (unneeded argument) was removed * refactor: lintr cleaning and roxygen2 documentation update * spelling: update wordlist * suggestions: nitpicks, returns m-kolomanski Co-authored-by: Mateusz Kołomański <[email protected]> * refactor: clarify with logical columns create_start_impute.R assignation * issue: eliminate all redundant dplyr/tidyr namespacing * issue: change base function to dplyr (base::merge > dplyr::inner_join) * fix: use describe/it in tests PKNCA_impute_method_additions & create_start_impute * nitpick, suggestion: nca.R add backlash and de-namespace mutate Co-authored-by: Mateusz Kołomański <[email protected]> * fix: filtering of dosno/analyte in displayed in `Data Selection` tab table * fix: crash on slope_selector due to filtering results with NA lambda.z * style: lintr clean code * style: lintr code cleaning * fix: remove redundant inst/WORDLIST.txt --------- Co-authored-by: Mateusz Kołomański <[email protected]>
- Loading branch information