Enhancement: NCA for multiple analytes #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3
Description
The current used PKNCA package allows the analysis to be run on multiple analytes simultaneously, however our current implementation only provides input selections for one analyte at a time. This can be changed in order to fully satisfy the user's needs.
Definition of Done
ANALYTE,DOSNO) and new ones (PCSPEC)How to test:
I have uploaded a dummy dataset with multiple analytes and mutliple matrices in the inst/shiny/data file. (its just the same as the dummyRO but copy and pasted data with ANALYTE or PCSPEC changed. Upload this file and test with different analytes.
Contributor checklist
Notes to reviewer
This pull request is limited to the main NCA - setup and results.
I updated the slope selector partially, but noticed a few bugs that are semi-related to the multiple analyte feature, but not completely, so I will be addressing them in separate issues #165 and #120, so that this issue does not become too big.