Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #466 #456 #480 deprecation 20; devcontainer; >=4.1 #481

Merged
merged 58 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from 50 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
ef2f6c5
docs: #466 deprecate 2.0
bms63 Oct 7, 2024
5c00f05
docs: #466 unit tests and roxygen
bms63 Oct 8, 2024
a78fc84
chore: #466 news
bms63 Oct 8, 2024
ead0e13
chore: #466 pkgdown yml
bms63 Oct 8, 2024
823ff6c
Update vignettes/programming_strategy.Rmd
bms63 Oct 9, 2024
56eec03
Update vignettes/programming_strategy.Rmd
bms63 Oct 9, 2024
76e4a13
Update vignettes/programming_strategy.Rmd
bms63 Oct 9, 2024
c9304fd
Update vignettes/programming_strategy.Rmd
bms63 Oct 9, 2024
f0d67ef
Update vignettes/programming_strategy.Rmd
bms63 Oct 9, 2024
9b55526
Merge branch 'main' into 466-deprecation-20
bms63 Oct 9, 2024
03dc9a0
feat: #466 inform function skeleton and tests
bms63 Nov 15, 2024
8245639
Merge branch '466-deprecation-20' of https://github.com/pharmaverse/a…
bms63 Nov 15, 2024
39e5712
Merge branch 'main' into 466-deprecation-20
bms63 Nov 15, 2024
6c37370
feat: looking at snapshot options with lifecycle
bms63 Nov 15, 2024
aec78d9
Merge branch '466-deprecation-20' of https://github.com/pharmaverse/a…
bms63 Nov 15, 2024
94d4c79
docs: #466 news entry for function and some general guidance for refe…
bms63 Nov 15, 2024
2ce81a7
docs: #466 inserted details in guidance
bms63 Nov 15, 2024
1582679
docs: #466 feedback from review
bms63 Nov 15, 2024
9c97317
docs: #466 more feedback adopted from review
bms63 Nov 15, 2024
db723a9
docs: #466 lets read!
bms63 Dec 6, 2024
ceff2f0
chore: #466 that lintr life
bms63 Dec 6, 2024
9db1653
chore: #466 making it work again
bms63 Dec 6, 2024
445eb67
chore: #466 style me baby!!
bms63 Dec 6, 2024
672287a
chore: #466 lints and docs
bms63 Dec 6, 2024
df5bfbe
chore: #446 unclear on doc updates
bms63 Dec 6, 2024
1738a8e
Merge branch 'main' into 466-deprecation-20
ddsjoberg Dec 6, 2024
bcf8394
docs: #466 wordsmithing fun for deprecation!!
bms63 Dec 18, 2024
6058d0c
Merge branch '466-deprecation-20' of https://github.com/pharmaverse/a…
bms63 Dec 18, 2024
f59f52e
chore: #466 styling and spelling
bms63 Dec 18, 2024
f26e630
chore: #466 docs
bms63 Dec 19, 2024
112dade
chore: #466 namespace
bms63 Dec 19, 2024
90dd2b3
feat: #466 arguments from lifecycle for environments
bms63 Dec 20, 2024
dd48670
chore: #466 argument hell
bms63 Dec 20, 2024
9afde36
feat: #466 include all arguments; todo: figure out NA issue
bms63 Dec 20, 2024
e29b860
docs: #466 getting pretty; environment tweaks
bms63 Dec 22, 2024
1fdaab5
documentation udpate
ddsjoberg Dec 23, 2024
92f4989
doc update
ddsjoberg Dec 23, 2024
b027426
doc update
ddsjoberg Dec 23, 2024
569cf71
chore: #466 spelling
bms63 Dec 23, 2024
23a17bd
Update admiraldev.Rproj
bms63 Dec 23, 2024
de54cd2
docs: #466 improving msg
bms63 Jan 8, 2025
3578ff9
Merge branch 'main' into 466-deprecation-20
bms63 Jan 8, 2025
1b8a81e
chore: #466 indentation
bms63 Jan 10, 2025
9999644
docs: #466 finalize dep prog strat
bms63 Jan 11, 2025
2036e25
chore: #466 #480 removed devcontainer; spelling
bms63 Jan 11, 2025
9096afc
docs: #456 upversion R in description
bms63 Jan 11, 2025
2b152cf
chore: news entries for all issues
bms63 Jan 11, 2025
e8cfe19
#466 deprecation: fix NEWS
bundfussr Jan 13, 2025
d6c6909
fix: #466 PR review updates
bms63 Jan 13, 2025
ec0a60d
fix: #466 PR review updates
bms63 Jan 13, 2025
8f35356
Update vignettes/programming_strategy.Rmd
bms63 Jan 14, 2025
54e93db
Update vignettes/programming_strategy.Rmd
bms63 Jan 14, 2025
8bf12b3
chore: #466 style dep functions
bms63 Jan 14, 2025
b5a8ece
fix: merge conflict
bms63 Jan 14, 2025
0769c48
#466 deprecation: update phase 2 of unit tests
bundfussr Jan 14, 2025
76bf54c
fix: #466 comments from PR review
bms63 Jan 14, 2025
4d387c5
chore: #466 wordsmith
bms63 Jan 14, 2025
6327f33
#466 deprecation: update changes to deprecated function
bundfussr Jan 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 0 additions & 76 deletions .devcontainer/4.1/devcontainer.json

This file was deleted.

76 changes: 0 additions & 76 deletions .devcontainer/4.2/devcontainer.json

This file was deleted.

76 changes: 0 additions & 76 deletions .devcontainer/devcontainer.json

This file was deleted.

11 changes: 0 additions & 11 deletions .devcontainer/postCreateCommand.sh

This file was deleted.

8 changes: 0 additions & 8 deletions .devcontainer/rstudio-prefs.json

This file was deleted.

5 changes: 0 additions & 5 deletions .devcontainer/rstudio.sh

This file was deleted.

2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ URL: https://pharmaverse.github.io/admiraldev/,
https://github.com/pharmaverse/admiraldev/
BugReports: https://github.com/pharmaverse/admiraldev/issues
Depends:
R (>= 4.0)
R (>= 4.1)
Imports:
cli (>= 3.0.0),
dplyr (>= 1.0.5),
Expand Down
27 changes: 19 additions & 8 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,33 @@ check whether the vector has a specific length. (#473)

## Breaking Changes

- The following functions are entering the next phase of the deprecation process: (#459)
- `{admiraldev}` is only compatible with R version >=4.1 (#456)

- - The following function arguments are entering the next phase of the [deprecation process](https://pharmaverse.github.io/admiraldev/articles/programming_strategy.html#deprecation): (#459)

**Phase 1 (message)**

No functions or arguments in this Phase

### Phase 1 (warning)
**Phase 2 (warning)**

No functions or arguments in this Phase

### Phase 2 (error)
**Phase 3 (error)**

No functions or arguments in this Phase

### Phase 3 (removed)
- The argument `quosures` was removed in the functions `vars2chr(quosures)`, `replace_values_by_names(quosures)`, and `get_source_vars(quosures)`
- Removed at v1.0.0 `assert_named_expr()`
- Removed at v1.0.0 `assert_has_variables()`
- Removed at v1.0.0 `assert_function_param()`
**Phase 4 (removed)**
- The argument `quosures` was removed in the functions `vars2chr(quosures)`, `replace_values_by_names(quosures)`, and `get_source_vars(quosures)`
- Removed at v1.0.0 `assert_named_expr()`
- Removed at v1.0.0 `assert_has_variables()`
- Removed at v1.0.0 `assert_function_param()`

## Documentation
- Deprecation Strategy updated for the long haul! (#466)

## Other
- `devcontainer` files removed (#480)

# admiraldev 1.1.0

Expand Down
5 changes: 2 additions & 3 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ Samia
Slama
Syed
TAs
TBD
TOC
TTE
USUBJID
Expand All @@ -67,7 +66,6 @@ advs
anonymized
behaviour
cmd
codebase
codeowner
cyclomatic
datatable
Expand All @@ -85,9 +83,9 @@ funder
hotfix
hotfixes
insightsengineering
lifecycle
linter
lintr
lockfile
onboarding
optionality
pharmaverse
Expand All @@ -96,6 +94,7 @@ pre
proc
programmatically
quosures
regexpr
repo
reproducibility
roxygen
Expand Down
Loading
Loading