feat/async-tools #1720
Open
feat/async-tools #1720
+228
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkbrnd
reviewed
Jan 9, 2025
| @@ -125,6 +125,8 @@ class Agent(BaseModel): | |||
| # forces the model to call that tool. | |||
| # "none" is the default when no tools are present. "auto" is the default if tools are present. | |||
| tool_choice: Optional[Union[str, Dict[str, Any]]] = None | |||
| # Allow async execution of tools | |||
| async_tools: bool = False | |||
There was a problem hiding this comment.
How about async_tool_calling?
There was a problem hiding this comment.
@ysolanky i think async tool calling should be true by default on arun, it doesnt make sense to ask users to select a flag which boots perf
Comment on lines
+525
to
+526
| if self.async_tools: | ||
| self.model.async_tools = True |
There was a problem hiding this comment.
Suggested change
| if self.async_tools: | |
| self.model.async_tools = True | |
| self.model.async_tools = self.async_tools |
| # -*- Stop function call timer | ||
| function_call_timer.stop() | ||
|
|
||
| for function_call_success, fc in zip(results, function_calls): |
There was a problem hiding this comment.
Suggested change
| for function_call_success, fc in zip(results, function_calls): | |
| for function_call_success, func_call in zip(results, function_calls): |
| for function_call_success, fc in zip(results, function_calls): | ||
| function_call_output: Optional[Union[List[Any], str]] = "" | ||
| if isinstance(fc.result, (GeneratorType, collections.abc.Iterator)): | ||
| for item in fc.result: |
There was a problem hiding this comment.
You can just cast the generator output to a list.
| function_call_timer.stop() | ||
|
|
||
| for function_call_success, fc in zip(results, function_calls): | ||
| function_call_output: Optional[Union[List[Any], str]] = "" |
There was a problem hiding this comment.
Can't we really return anything?
Comment on lines
+783
to
+804
| if self.async_tools: | ||
| if ( | ||
| await self.ahandle_tool_calls( | ||
| assistant_message=assistant_message, | ||
| messages=messages, | ||
| model_response=model_response, | ||
| tool_role=tool_role, | ||
| ) | ||
| is not None | ||
| ): | ||
| return await self.ahandle_post_tool_call_messages(messages=messages, model_response=model_response) | ||
| else: | ||
| if ( | ||
| self.handle_tool_calls( | ||
| assistant_message=assistant_message, | ||
| messages=messages, | ||
| model_response=model_response, | ||
| tool_role=tool_role, | ||
| ) | ||
| is not None | ||
| ): | ||
| return await self.ahandle_post_tool_call_messages(messages=messages, model_response=model_response) |
There was a problem hiding this comment.
This should probably be a helper in the base?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Async tool execution
Type of change
Please check the options that are relevant:
Checklist