check if epochlength > --Xchain-pruning-blocks-retained and fail vali…

…dation if it does(hyperledger#7963) Signed-off-by: philosup <[email protected]>
philosup · Jan 21, 2025 · 7b821ab · 7b821ab
1 parent 5933a2a
commit 7b821ab
Showing 1 changed file with 17 additions and 7 deletions.
diff --git a/besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java b/besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java
@@ -1588,13 +1588,23 @@ private void validateRpcWsOptions() {
   }
 
   private void validateChainDataPruningParams() {
-    if (unstableChainPruningOptions.getChainDataPruningEnabled()
-        && unstableChainPruningOptions.getChainDataPruningBlocksRetained()
-            < unstableChainPruningOptions.getChainDataPruningBlocksRetainedLimit()) {
-      throw new ParameterException(
-          this.commandLine,
-          "--Xchain-pruning-blocks-retained must be >= "
-              + unstableChainPruningOptions.getChainDataPruningBlocksRetainedLimit());
+    if (unstableChainPruningOptions.getChainDataPruningEnabled()) {
+      final GenesisConfigOptions genesisConfigOptions = readGenesisConfigOptions();
+      if (unstableChainPruningOptions.getChainDataPruningBlocksRetained()
+          < unstableChainPruningOptions.getChainDataPruningBlocksRetainedLimit()) {
+        throw new ParameterException(
+            this.commandLine,
+            "--Xchain-pruning-blocks-retained must be >= "
+                + unstableChainPruningOptions.getChainDataPruningBlocksRetainedLimit());
+      } else if (genesisConfigOptions.isQbft()
+          && unstableChainPruningOptions.getChainDataPruningBlocksRetained()
+              < genesisConfigOptions.getQbftConfigOptions().getEpochLength()) {
+        throw new ParameterException(
+            this.commandLine,
+            "--Xchain-pruning-blocks-retained must be >= epochlength("
+                + genesisConfigOptions.getQbftConfigOptions().getEpochLength()
+                + ") for QBFT networks");
+      }
     }
   }