Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libphoenix: make assert macro posix compliant #389

Merged
merged 1 commit into from
Oct 30, 2024
Merged

libphoenix: make assert macro posix compliant #389

merged 1 commit into from
Oct 30, 2024

Conversation

adamdebek
Copy link
Contributor

JIRA: RTOS-964

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@adamdebek
libphoenix: make assert macro posix compliant
6efbd5e 
POSIX states that assert macro should write fail information on stderr

JIRA: RTOS-964
@adamdebek adamdebek requested a review from damianloew October 29, 2024 19:46
@github-actions GitHub Actions
Copy link

Unit Test Results

7 787 tests  ±0   7 069 ✅ ±0   41m 59s ⏱️ + 1m 43s
  461 suites ±0     718 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 6efbd5e. ± Comparison against base commit aefed2d.

damianloew
damianloew approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it at once

@adamdebek adamdebek merged commit 175c1e6 into master Oct 30, 2024
36 checks passed
@adamdebek adamdebek deleted the adamdebek/RTOS-964 branch October 30, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianloew damianloew damianloew approved these changes

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamdebek @agkaminski @damianloew