Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generic image_builder #206

Merged
merged 5 commits into from
Sep 30, 2024
Merged

add generic image_builder #206

merged 5 commits into from
Sep 30, 2024

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Sep 27, 2024

Description

  • scripts: add image_builder
    New generic tool for generating target plo scripts and partition / disk
    images.
  • scripts/g716: enhance size param parsing
  • strip.py: add ELF program headers parser
  • build: build host tools with ASAN disabled
    In phoenixrtos/build there is no libasan.so.8 installed by default which
    results in broken host tools.
  • build.sh: set all static output dirs before sourcing target/project script

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
    Building: add new dependencies phoenix-rtos-doc#212
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

In phoenixrtos/build there is no libasan.so.8 installed by default which
results in broken host tools.

JIRA: CI-494
PREFIX_H PREFIX_ROOTFS CROSS CFLAGS CXXFLAGS LDFLAGS CC LD AR AS MAKEFLAGS DEVICE_FLAGS PLO_SCRIPT_DIR\
PREFIX_SYSROOT LIBPHOENIX_DEVEL_MODE

source ./build.project

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Not following: ./build.project: openBinaryFile: does not exist (No such file or directory) SC1091

Copy link

github-actions bot commented Sep 27, 2024

Unit Test Results

6 800 tests   6 174 ✅  31m 20s ⏱️
  386 suites    626 💤
    1 files        0 ❌

Results for commit f7fc6cf.

♻️ This comment has been updated with latest results.

@nalajcie nalajcie force-pushed the nalajcie/new_plo_scripts branch from c2785ed to 1981594 Compare September 30, 2024 14:08
Copy link
Member

@anglov anglov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to me for merge as-is my comments are mainly notes, typos or ideas for future

scripts/image_builder.py Show resolved Hide resolved
scripts/image_builder.py Show resolved Hide resolved
scripts/image_builder.py Show resolved Hide resolved
scripts/image_builder.py Outdated Show resolved Hide resolved
scripts/image_builder.py Show resolved Hide resolved
scripts/image_builder.py Show resolved Hide resolved
scripts/image_builder.py Show resolved Hide resolved
@nalajcie nalajcie force-pushed the nalajcie/new_plo_scripts branch from 1981594 to 5838e8d Compare September 30, 2024 15:10
New generic tool for generating target plo scripts and partition / disk
images.

JIRA: CI-494
@nalajcie nalajcie force-pushed the nalajcie/new_plo_scripts branch from 5838e8d to f7fc6cf Compare September 30, 2024 15:11
@nalajcie nalajcie merged commit 9270dc4 into master Sep 30, 2024
34 checks passed
@nalajcie nalajcie deleted the nalajcie/new_plo_scripts branch September 30, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants