Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.common: fix ld version parsing #216

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Oct 23, 2024

Fix ld version parsing not working for version format <Major>.<Minor>.<Patch>
Add explicit error when version cannot be parsed.

JIRA: RTOS-959

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Fix ld version parsing not working for version format <Major>.<Minor>.<Patch>
Add explicit error when version cannot be parsed.

JIRA: RTOS-959
@badochov badochov requested a review from anglov October 23, 2024 13:29
@badochov
Copy link
Contributor Author

@anglov can you check if this fixes you issue? Locally I tested by replacing ld --version with echo 2.34.1

Copy link

Unit Test Results

7 787 tests  ±0   7 069 ✅ ±0   40m 52s ⏱️ - 1m 51s
  461 suites ±0     718 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 848ca6d. ± Comparison against base commit e268324.

Copy link
Member

@anglov anglov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It work's
LGTM

@badochov badochov merged commit 8e072ed into master Oct 23, 2024
36 checks passed
@badochov badochov deleted the badochov/ld-version branch October 23, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants