Adapt USB stack to work on ia32 #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: RTOS-937
The reply data was not copied by the responder to the buffer address provided by the sender. JIRA: RTOS-937
This was referenced Nov 22, 2024
adamgreloch
force-pushed
the
adamgreloch/RTOS-937
branch
from
65405df to
3514ec3
Compare
adamgreloch
force-pushed
the
adamgreloch/RTOS-937
branch
from
3514ec3 to
257c6d9
Compare
This allows usb to be loaded from syspage (e.g. so that umass can be used for rootfs mounting) JIRA: RTOS-937
adamgreloch
force-pushed
the
adamgreloch/RTOS-937
branch
from
257c6d9 to
1f3319f
Compare
agkaminski
reviewed
Dec 6, 2024
| @@ -64,6 +64,7 @@ typedef struct usb_transfer { | |||
| unsigned long rid; | |||
| unsigned int port; | |||
| pid_t pid; | |||
| msg_t msg; | |||
There was a problem hiding this comment.
pid field became redundant. Please note that msg_t is quite hefty (150 bytes)
There was a problem hiding this comment.
True, this was only a temporary solution to make synchronous transfers work before doing a rework - I could have added a comment about this. A final more thought through solution is in #35
drvBind always succeeded even when no driver has been found for a device JIRA: RTOS-937
drvBind races with drvAdd. This change ensures that devices won't be orphaned if added by hcd before adding the corresponding driver in the single-driver scenario. This does not fix the race in case of multi-driver scenario, though, hence the "orphaned" todo is left untouched JIRA: RTOS-937
adamgreloch
force-pushed
the
adamgreloch/RTOS-937
branch
from
11073b9 to
d151c98
Compare
JIRA: RTOS-937
adamgreloch
force-pushed
the
adamgreloch/RTOS-937
branch
from
d151c98 to
864d4f9
Compare
14 tasks
…able JIRA: RTOS-937
adamgreloch
force-pushed
the
adamgreloch/RTOS-937
branch
from
864d4f9 to
204e45a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various additions and fixes necessary for making the USB work on ia32
JIRA: RTOS-937
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
usb: Adapt USB stack to work on ia32 phoenix-rtos-devices#525