Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bc (c7e83fbbbcde9f54affc09424d032c38492a3ff4) #1992

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Update bc (c7e83fbbbcde9f54affc09424d032c38492a3ff4) #1992

merged 1 commit into from
Jan 14, 2025

Conversation

Fan2Shrek
Copy link
Contributor

No description provided.

devnexen
devnexen reviewed Jan 14, 2025
View reviewed changes
reference/bc/ini.xml Outdated Show resolved Hide resolved
@devnexen
Copy link
Member

can you rebase please ?

@devnexen
Copy link
Member

devnexen commented Jan 14, 2025 •
edited
Loading

Oh I see there is legit pb with the previous commit, see for example

reference/bc/bcmath/number/divmod.xml 31:13

there is one too many <classname> tag

@devnexen
Copy link
Member

you can either create a separate PR to fix all of these or fixing here.

@Fan2Shrek
Copy link
Contributor Author

Should be fix,

Sorry for that 😅

devnexen
devnexen approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@devnexen devnexen merged commit a60bc33 into php:master Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fan2Shrek @devnexen