Merge pull request #474 from phpmetrics/fixes_permissions_path

Fixes issues with paths
phpmetrics · Mar 24, 2022 · ac7b10d · ac7b10d
2 parents 6e1b0d6 + dfb7250
commit ac7b10d
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 21 deletions.
diff --git a/src/Hal/Application/Application.php b/src/Hal/Application/Application.php
@@ -2,6 +2,7 @@
 
 namespace Hal\Application;
 
+use Exception;
 use Hal\Application\Config\ConfigException;
 use Hal\Application\Config\Parser;
 use Hal\Application\Config\Validator;
@@ -87,13 +88,19 @@ public function run(array $argv)
         (new ViolationParser($config, $output))->apply($metrics);
 
         // report
-        (new Report\Cli\Reporter($config, $output))->generate($metrics);
-        (new Report\Cli\SearchReporter($config, $output))->generate($metrics);
-        (new Report\Html\Reporter($config, $output))->generate($metrics);
-        (new Report\Csv\Reporter($config, $output))->generate($metrics);
-        (new Report\Json\Reporter($config, $output))->generate($metrics);
-        (new Report\Json\SummaryReporter($config, $output))->generate($metrics);
-        (new Report\Violations\Xml\Reporter($config, $output))->generate($metrics);
+        try {
+            (new Report\Cli\Reporter($config, $output))->generate($metrics);
+            (new Report\Cli\SearchReporter($config, $output))->generate($metrics);
+            (new Report\Html\Reporter($config, $output))->generate($metrics);
+            (new Report\Csv\Reporter($config, $output))->generate($metrics);
+            (new Report\Json\Reporter($config, $output))->generate($metrics);
+            (new Report\Json\SummaryReporter($config, $output))->generate($metrics);
+            (new Report\Violations\Xml\Reporter($config, $output))->generate($metrics);
+        } catch (Exception $e) {
+            $output->writeln(sprintf('<error>Cannot generate report: %s</error>', $e->getMessage()));
+            $output->writeln('');
+            exit(1);
+        }
 
         // exit status
         $shouldExitDueToCriticalViolationsCount = 0;

diff --git a/src/Hal/Application/Config/File/ConfigFileReaderJson.php b/src/Hal/Application/Config/File/ConfigFileReaderJson.php
@@ -11,7 +11,7 @@ class ConfigFileReaderJson implements ConfigFileReaderInterface
     /**
      * @var string
      */
-    private $filename;
+    protected $filename;
 
     /**
      * @param string $filename

diff --git a/src/Hal/Application/Config/File/ConfigFileReaderYaml.php b/src/Hal/Application/Config/File/ConfigFileReaderYaml.php
@@ -6,19 +6,6 @@
 
 class ConfigFileReaderYaml extends ConfigFileReaderJson implements ConfigFileReaderInterface
 {
-    /**
-     * @var string
-     */
-    private $filename;
-
-    /**
-     * @param string $filename
-     */
-    public function __construct($filename)
-    {
-        $this->filename = $filename;
-    }
-
     /**
      * @param Config $config
      */

diff --git a/src/Hal/Report/Html/Reporter.php b/src/Hal/Report/Html/Reporter.php
@@ -7,6 +7,7 @@
 use Hal\Metric\Consolidated;
 use Hal\Metric\Group\Group;
 use Hal\Metric\Metrics;
+use RuntimeException as RuntimeExceptionAlias;
 
 class Reporter
 {
@@ -103,6 +104,11 @@ public function generate(Metrics $metrics)
         if (!file_exists($logDir . '/fonts')) {
             mkdir($logDir . '/fonts', 0755, true);
         }
+
+        if (!is_writable($logDir)) {
+            throw new RuntimeExceptionAlias(sprintf('Unable to write in the directory "%s"', $logDir));
+        }
+
         recurse_copy($this->templateDir . '/html_report/js', $logDir . '/js');
         recurse_copy($this->templateDir . '/html_report/css', $logDir . '/css');
         recurse_copy($this->templateDir . '/html_report/images', $logDir . '/images');
@@ -193,6 +199,10 @@ public function generate(Metrics $metrics)
      */
     public function renderPage($source, $destination, Consolidated $consolidated, $history)
     {
+        if (!is_writable(dirname($destination))) {
+            throw new RuntimeExceptionAlias(sprintf('Unable to write in the directory "%s"', dirname($destination)));
+        }
+
         $this->sum = $sum = $consolidated->getSum();
         $this->avg = $avg = $consolidated->getAvg();
         $this->classes = $classes = $consolidated->getClasses();