Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate code based on 2024-10 api spec after two changes: uri & indexTags #160

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

rohanshah18
Copy link
Contributor

Problem

Made two changes to the open api specs.

Solution

Regenerate code based on the latest changes in the open api specs. Following commands were ran to generate the code:

git submodule init && git submodule update
./codegen/build-oas.sh 2024-10

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Existing integration tests should run successfully.

@rohanshah18 rohanshah18 marked this pull request as ready for review October 22, 2024 21:36
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting these changes pulled in.

@rohanshah18 rohanshah18 merged commit 7af4587 into rshah/release-candidate/2024-10 Oct 22, 2024
6 of 7 checks passed
@rohanshah18 rohanshah18 deleted the rshah/codegen branch October 22, 2024 21:47
rohanshah18 added a commit that referenced this pull request Oct 24, 2024
…dexTags (#160)

## Problem

Made two changes to the open api specs.

## Solution

Regenerate code based on the latest changes in the open api specs.
Following commands were ran to generate the code:
```
git submodule init && git submodule update
./codegen/build-oas.sh 2024-10
```

## Type of Change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)

## Test Plan

Existing integration tests should run successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants