-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Raise an exception when trying to create a smart collection/playlist with items #1377
Conversation
actually, i'm not sure what was happening. as the "items" doesn't seem to be passed to the |
so, what was happening was that it called this URL:
which seems like smart playlist with no filters (so it contains whole library) |
Maybe what could be done here instead is to raise an error if no filters are provided |
I would expect a smart playlist to contain the entire library if no filters are provided. I don't think we should restrict that. |
So the change here should be fine. It would disallow using smart and items, possibly not confusing the user. user can still create smart playlist without filters as long as they don't also pass items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add the same exception for smart collections?
python-plexapi/plexapi/collection.py
Lines 505 to 506 in abcab4f
if smart: | |
return cls._createSmart(server, title, section, limit, libtype, sort, filters, **kwargs) |
Co-authored-by: JonnyWong16 <[email protected]>
Description
Fixes #1375
Type of change
Please delete options that are not relevant.
Checklist: