#8333 Fixes after review

pkp · Jul 24, 2024 · 43c7374 · 43c7374
1 parent c74e54c
commit 43c7374
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/classes/navigationMenu/NavigationMenuDAO.php b/classes/navigationMenu/NavigationMenuDAO.php
@@ -188,7 +188,7 @@ public function installSettings(?int $contextId, string $filename): bool
         $xmlParser = new PKPXMLParser();
         $tree = $xmlParser->parse($filename);
 
-        if ($contextId === Application::SITE_CONTEXT_ID) {
+        if ($contextId == Application::SITE_CONTEXT_ID) {
             $siteDao = DAORegistry::getDAO('SiteDAO'); /** @var SiteDAO $siteDao */
             $site = $siteDao->getSite();
         }
@@ -198,7 +198,7 @@ public function installSettings(?int $contextId, string $filename): bool
 
         foreach ($tree->getChildren() as $navigationMenuNode) {
             $site = $navigationMenuNode->getAttribute('site');
-            if ($contextId === Application::SITE_CONTEXT_ID && !$site) {
+            if ($contextId == Application::SITE_CONTEXT_ID && !$site) {
                 continue;
             }
 

diff --git a/classes/navigationMenu/NavigationMenuItemDAO.php b/classes/navigationMenu/NavigationMenuItemDAO.php
@@ -112,7 +112,7 @@ public function getByTypeAndTitleLocaleKey(?int $contextId, string $menuItemType
      *
      * @return DAOResultFactory<NavigationMenuItem>
      */
-    public function getByType(string $type, ?int $contextId = Application::SITE_CONTEXT_ID_ALL)
+    public function getByType(string $type, ?int $contextId = Application::SITE_CONTEXT_ID_ALL): DAOResultFactory
     {
         $params = [$type];
         if ($contextId !== Application::SITE_CONTEXT_ID_ALL) {