Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update show patrol popup at room entering #3211

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

tyrosine1153
Copy link
Contributor

@tyrosine1153 tyrosine1153 commented Oct 17, 2023

Description

접속했을 때 방치보상 받을 수 있는 상황이면 바로 방치보상 팝업창 띄우기

  • Refactor EventReleaseNotePopup, unread check
  • Update show patrol popup at room entering
  • Refactor patrol reward popup (refer commit description)
  • Add mixpanel analyzer

@tyrosine1153 tyrosine1153 requested a review from a team as a code owner October 17, 2023 11:02
@tyrosine1153 tyrosine1153 changed the title Feature/patrol popup Update show patrol popup at room entering Oct 17, 2023
- call PatrolRewardPopup.InitializePatrolReward() at States.SelectAvatarAsync()
- refactor PatrolRewardMenu
- delete _disposables in PatrolRewardPopup
- call PatrolReward.Initialize() at PatrolReward
@tyrosine1153 tyrosine1153 merged commit b797fb1 into fast-track/70.2.0 Oct 18, 2023
1 check passed
@tyrosine1153 tyrosine1153 deleted the feature/patrol-popup branch October 18, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants