Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce and apply States.NCG #3214

Merged

Conversation

boscohyun
Copy link
Contributor

@boscohyun boscohyun commented Oct 18, 2023

Background

There is the GoldCurrencyState which is contains the NCG currency of a Nine Chronicles blockchain network.
It means the NCG currency can be different between another networks.(ref)
For this reason, clients need to get the NCG currency that are stored in the blockchain state each time.

Features

  • Get the NCG currency from blockchain state and store to States each time.
  • Remove ActionHandler.GoldCurrency.
  • Use States.NCG instead of others.

@boscohyun boscohyun self-assigned this Oct 18, 2023
@boscohyun boscohyun force-pushed the feat/implement-states-ncg branch from a4c629d to 05b1edb Compare October 18, 2023 05:53
@boscohyun boscohyun marked this pull request as ready for review October 18, 2023 05:53
@boscohyun boscohyun requested a review from a team as a code owner October 18, 2023 05:53
@boscohyun boscohyun requested a review from a team October 18, 2023 05:53
@boscohyun boscohyun merged commit 0644b01 into feat/enhanced-game-state-management Oct 18, 2023
1 check passed
@boscohyun boscohyun deleted the feat/implement-states-ncg branch October 18, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants