-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TimeLimitText at mobile shop product ui #3679
Conversation
1577ace
to
8281a1e
Compare
foreach (var item in preDiscountPrice) | ||
{ | ||
var originPrice = (_puchasingData.metadata.localizedPrice * ((decimal)100 / (decimal)(100 - _data.Discount))); | ||
var origin = MobileShop.GetPrice(_puchasingData.metadata.isoCurrencyCode, originPrice); | ||
var originPrice = metadata.localizedPrice * ((decimal)100 / (100 - _data.Discount)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, Discount
field may have set by '100'. then, It can throw DivideByZeroException.
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Description
모바일 샵 패키지에 남은 시간 표기해주기