New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ Slightly optimized `BlockMarshaler` #3454

Merged

greymistcube merged 2 commits into planetarium:main from greymistcube:refactor/micro-optimization

Oct 16, 2023

Contributor

greymistcube commented Oct 12, 2023 •

edited

Loading

⚡

I'd say we need to get rid of Dictionary.GetValue<T>() from Bencodex. 🙄

Albeit trivial, it's not intuitively clear that its behavior is the same as (T)dict[key].
It is longer to type. So it isn't even that convenient to use.
It is also missing Dictionary.GetValue<T>(IKey), which should be the base implementation.

The only upside is not having to use additional pair of parentheses in certain cases. 🙄


          Optimized BlockMarshaler

0e8cb7a

auto-assign bot assigned greymistcube

greymistcube requested a review from OnedgeLee

October 12, 2023 12:59


          Changelog

bd21852

OnedgeLee approved these changes

View reviewed changes

greymistcube merged commit 559eafd into planetarium:main

greymistcube deleted the refactor/micro-optimization branch

January 4, 2024 05:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet