-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Remove IRichStore
#3564
🧹 Remove IRichStore
#3564
Conversation
56df40f
to
9184a49
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
799a291
into
planetarium:3.9-maintenance
See #3562 for context. Again, I emphasize that this needs to be completely reimplemented after clearly deciding on storage policy (how to use it, what to store, etc.).
Note:
I think
IntGraphType
defaults tonull
, which in turn means there is no limit ontransactions
query by default. If that is the case, this is a dangerous behavior and should be fixed. 😶Regardless of using
IRichStore
(even if it was properly implemented) such behavior is unwarranted.