adds EMAIL_HOST, EMAIL_PORT if outgoing email is enabled. #776
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
reviewed
Apr 23, 2024
| @@ -159,6 +159,9 @@ def decode(variable): | |||
| STATIC_ROOT = os.path.join(os.getenv('PLATFORM_APP_DIR'), 'static') | |||
| if (os.getenv('PLATFORM_PROJECT_ENTROPY') is not None): | |||
| SECRET_KEY = os.getenv('PLATFORM_PROJECT_ENTROPY') | |||
| if (os.getenv('PLATFORM_SMTP_HOST') is not None): | |||
| EMAIL_HOST = os.getenv("PLATFORM_SMTP_HOST") | |||
| EMAIL_PORT = 25 | |||
There was a problem hiding this comment.
I guess for local dev one should then modify the code accordingly
There was a problem hiding this comment.
@lsmith77 Is that alright for you? Does it work to recommend that a user mock this variable locally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds EMAIL_HOST, EMAIL_PORT to settings.py if outgoing email is enabled for the environment.
Closes #774
Related Issue
#744
Please drop a link to the issue here:
#774