Skip to content

Commit

Permalink
Merge pull request #806 from mkurz/slick35_scala3_52x
Browse files Browse the repository at this point in the history
[5.2.x] Slick 3.5.0-RC1 + Scala 3 support
  • Loading branch information
mkurz authored Feb 21, 2024
2 parents cce7f50 + add9c9e commit 8ebb10a
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:

push:
branches:
- 5.2.x # Check branch after merge
- 5.3.x # Check branch after merge

concurrency:
# Only run once for latest commit per ref and cancel other (previous) runs.
Expand Down Expand Up @@ -38,7 +38,7 @@ jobs:
uses: playframework/.github/.github/workflows/cmd.yml@v3
with:
java: 17, 11
scala: 2.13.x
scala: 2.13.x, 3.x
cmd: sbt ++$MATRIX_SCALA test

finish:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependency-graph.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Dependency Graph
on:
push:
branches:
- 5.2.x
- 5.3.x

concurrency:
# Only run once for latest commit per ref and cancel other (previous) runs.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Publish
on:
push:
branches: # Snapshots
- 5.2.x
- 5.3.x
tags: ["**"] # Releases

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Release Drafter
on:
push:
branches:
- 5.2.x
- 5.3.x

jobs:
update_release_draft:
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ To use play-slick, you need to add the following dependencies:

```scala
libraryDependencies ++= Seq(
"com.typesafe.play" %% "play-slick" % "5.2.0",
"com.typesafe.play" %% "play-slick-evolutions" % "5.2.0"
"com.typesafe.play" %% "play-slick" % "5.3.0",
"com.typesafe.play" %% "play-slick-evolutions" % "5.3.0"
)
```

Expand All @@ -47,6 +47,7 @@ The Play Slick plugin supports several different versions of Play and Slick.

| Plugin version | Play version | Slick version | Scala version |
|----------------|--------------|---------------|----------------------|
| 5.3.x | 2.9.0 | 3.5.0+ | 2.13.x/3.3.x |
| 5.2.x | 2.9.0 | 3.4.1 | 2.13.x |
| 5.1.x | 2.8.16 | 3.4.1+ | 2.12.x/2.13.x |
| 5.0.x | 2.8.x | 3.3.2+ | 2.12.x/2.13.x |
Expand Down
9 changes: 7 additions & 2 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ lazy val commonSettings = Seq(
// Work around https://issues.scala-lang.org/browse/SI-9311
scalacOptions ~= (_.filterNot(_ == "-Xfatal-warnings")),
scalaVersion := "2.13.12",
crossScalaVersions := Seq("2.13.12"),
crossScalaVersions := Seq("2.13.12", "3.3.1"),
pomExtra := scala.xml.NodeSeq.Empty, // Can be removed when dropping interplay
developers += Developer(
"playframework",
Expand All @@ -45,6 +45,7 @@ lazy val `play-slick` = (project in file("src/core"))
.settings(mimaSettings)
.settings(
mimaBinaryIssueFilters ++= Seq(
ProblemFilters.exclude[DirectMissingMethodProblem]("play.api.db.slick.HasDatabaseConfig.db"),
)
)
.settings(commonSettings)
Expand Down Expand Up @@ -73,7 +74,11 @@ val previousVersion: Option[String] = Some("5.2.0")
ThisBuild / mimaFailOnNoPrevious := false

def mimaSettings = Seq(
mimaPreviousArtifacts := previousVersion.map(organization.value %% moduleName.value % _).toSet,
mimaPreviousArtifacts := (if (CrossVersion.binaryScalaVersion(scalaVersion.value) == "3") {
Set.empty
} else {
previousVersion.map(organization.value %% moduleName.value % _).toSet
}),
mimaBinaryIssueFilters := Seq(
)
)
6 changes: 3 additions & 3 deletions docs/manual/working/scalaGuide/main/sql/slick/code/slick.sbt
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// #add-library-dependencies
libraryDependencies += "com.typesafe.play" %% "play-slick" % "5.2.0"
libraryDependencies += "com.typesafe.play" %% "play-slick" % "5.3.0"
// #add-library-dependencies

// #add-dependency-with-evolutions
libraryDependencies ++= Seq(
"com.typesafe.play" %% "play-slick" % "5.2.0",
"com.typesafe.play" %% "play-slick-evolutions" % "5.2.0"
"com.typesafe.play" %% "play-slick" % "5.3.0",
"com.typesafe.play" %% "play-slick-evolutions" % "5.3.0"
)
// #add-dependency-with-evolutions
2 changes: 1 addition & 1 deletion project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ object Dependencies {
object Version {
val play = _root_.play.core.PlayVersion.current

val slick = "3.4.1"
val slick = "3.5.0-RC1"
val h2 = "2.2.224"
}

Expand Down

0 comments on commit 8ebb10a

Please sign in to comment.