pex_main: always clean up exploded zip when exiting
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a pex file contains zip-unsafe files or is otherwise told to explode itself when it runs (e.g. via the `PEX_EXPLODE` environment variable), `pex_main` extracts its own contents to a temporary directory. However, it only deletes those files after the entry point script finishes executing provided that the script does not throw an exception. For large pex archives, this can quickly fill up the file system containing the temporary directory. Unconditionally delete the extracted contents of the pex when the entry point script finishes executing. Fixes please-build#131.
Birkalo
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a pex file contains zip-unsafe files or is otherwise told to explode itself when it runs (e.g. via the
PEX_EXPLODEenvironment variable),pex_mainextracts its own contents to a temporary directory. However, it only deletes those files after the entry point script finishes executing provided that the script does not throw an exception. For large pex archives, this can quickly fill up the file system containing the temporary directory.Unconditionally delete the extracted contents of the pex when the entry point script finishes executing.
Fixes #131.