CI: use interpreter provided by actions/setup-python
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`actions/setup-python` "installs" a non-standard Python interpreter in the CI environment by adding a directory containing it to `PATH`, but the updated `PATH` isn't inherited by the Please build sandbox, so the system-wide Python interpreter is always used. Pass through the value of `PATH` to the sandbox so that the correct `actions/setup-python` interpreter is used. Fixes please-build#127.
toastwaffle
approved these changes
Nov 5, 2024
|
This uncovers a few failures in >= 3.12 because distutils was removed from the stdlib - I'll fix that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/setup-python"installs" a non-standard Python interpreter in the CI environment by adding a directory containing it toPATH, but the updatedPATHisn't inherited by the Please build sandbox, so the system-wide Python interpreter is always used. Pass through the value ofPATHto the sandbox so that the correctactions/setup-pythoninterpreter is used.Fixes #127.