Get rid of load_module from import hooks #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
commented
Nov 18, 2024
| import unittest | ||
|
|
||
|
|
||
| class TestModuleDirImport(unittest.TestCase): |
There was a problem hiding this comment.
Weirdly we didn't seem to have anything that tested this sufficiently directly - I would have thought we must have but I got ModuleDirImport through them all with a deliberately busted implementation of exec_module...
| """Actually load a module that we said we'd handle in find_module.""" | ||
| module = import_module(fullname[len(self.prefix):]) | ||
| sys.modules[fullname] = module | ||
| module = import_module(spec.name[len(self.prefix):]) |
There was a problem hiding this comment.
I think maybe this is mildly not nice (it kind of does everything in create_module and leaves nothing for exec_module) but I can't find a convenient equivalent to break it into the two parts.
chrisnovakovic
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this has been deprecated since 3.4 (!), when you run it with a sufficiently debug Python it issues
DeprecationWarnings about it.Change to use
create_moduleandexec_modulewhich are the more modern way.