Fix exploding zip-unsafe pexes #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
commented
Nov 19, 2024
| deps = [ | ||
| "//third_party/python:confluent-kafka", | ||
| ], | ||
| labels = ["manual"], |
There was a problem hiding this comment.
sadly I can't just skip the test here because it fails before it even gets to the test without the updated pex tool. I'll remove this in the next PR.
chrisnovakovic
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we used to have a test for this but we probably lost it to time. Anyway, we need to get
ZipFileWithPermissionsfrom theplzmodule now, which requires getting it to be importable at the right time.Have added a test using confluent-kafka which isn't trivially zip-safe, even with SoImport.