-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix loading winfsp DLL on Windows #29
base: develop
Are you sure you want to change the base?
Conversation
this was upsettingly easy. however, it requires a trivial patch to reFUSE to be merged and released: pleiszenburg/refuse#29
This is now against develop instead of master, sorry about that. |
@s-m-e do you think you'll have a chance to look at this soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:+1 Looks good to me (without this change get sys not found traceback).
@@ -32,6 +32,7 @@ | |||
# +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ | |||
|
|||
import os | |||
import sys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super pedantic; I'd be tempted to import AFTER ctypes to be more Pythnonic (alphabetical sorted imports, note existing import os
could move too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'd be happy to do either or both of those small modifications. @s-m-e do you have any thoughts?
Unfortunately, no. Maybe you can reach s-m-e via his e-mail address. Alternatively, you could do the same as I did while waiting for |
or you could monkey patch the module by injecting the sys module into the _refactor locals before importing refuse.high
|
No description provided.