fix: add orientation handling #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added handlers to the useMeasure hook
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7a78500:
|
|
@drcmda, we'll want to upstream improvements here to use-measure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an orientation handler to useMeasure so that when the device rotates it correctly adjusts the canvas.
Right now, when a phone rotates the window resize event never fires so the canvas doesn't know it should change, and as the resize handler sets the css sizes directly on the canvas it causes it to bleed over the edge or if you go from horizontal to vertical causes it to leave a big black area in the viewport.
You can simulate this in chrome by using the developer tools device preview button. Load a mobile device, Load a canvas (typically a full size one) and then change the orientation with the orientation button.