Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified is_true_somewhere function to use integers instead of bools.… #102

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

bjpalmer
Copy link
Collaborator

@bjpalmer bjpalmer commented Dec 12, 2023

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary
Modifies the implementation of the the is_true_somewhere function to use integers instead of bools. This should get around some implementation issues that affect the build on Frontier.

Linked Issue(s)

… This

should get around some implementation issues.
@bjpalmer bjpalmer self-assigned this Dec 12, 2023
@bjpalmer bjpalmer requested a review from nkoukpaizan December 12, 2023 19:36
Copy link
Collaborator

@nkoukpaizan nkoukpaizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is passing and I have confirmed that it works on Frontier. I would leave the issue open to track the underlying MPI issue. I'll file a bug report for that.

@nkoukpaizan
Copy link
Collaborator

@cameronrutherford Can you merge this into develop?

@cameronrutherford cameronrutherford merged commit 3420fcc into develop Dec 12, 2023
12 checks passed
@bjpalmer bjpalmer deleted the testing/fix-mpi-bool branch December 12, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants