Feature/remove time dependency (#312)

* remove time from being necessary

* fix pylint and flake8

* update changelog

* poetry update

* update l2ss exception

* fix tests

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 ### Deprecated 
 ### Removed
+- Remove the time dependency when subsetting.
 ### Fixed
 - Updated xarray enhancement get_indexers_from_nd function for SMAP_RSS_L2_SSS_V6.
 - Fix minor bug in checking for empty indexers and same data bounds.

podaac/subsetter/subset.py

@@ -560,11 +560,7 @@ def compute_time_variable_name(dataset: xr.Dataset, lat_var: xr.Variable, total_
         if var_name not in total_time_vars and 'time' in var_name_time.lower() and dataset[var_name].squeeze().dims[0] in lat_var.squeeze().dims:
             return var_name
 
-    # OB.DAAC data does not have a time variable. Returning the following field of a composite time value to avoid exceptions.
-    if '__scan_line_attributes__day' in dataset.data_vars:
-        return '__scan_line_attributes__day'
-
-    raise ValueError('Unable to determine time variable')
+    return None
 
 
 def compute_utc_name(dataset: xr.Dataset) -> Union[str, None]:
@@ -1296,6 +1292,9 @@ def subset(file_to_subset: str, bbox: np.ndarray, output_file: str,
             time_var_names=time_var_names
         )
 
+        if not time_var_names and (min_time or max_time):
+            raise ValueError('Could not determine time variable')
+
         start_date = None
         if hdf_type and (min_time or max_time):
             dataset, start_date = tc.convert_to_datetime(dataset, time_var_names, hdf_type)

podaac/subsetter/subset_harmony.py

@@ -24,6 +24,7 @@
 from tempfile import mkdtemp
 import traceback
 from typing import List, Union
+import sys
 
 import pystac
 from pystac import Asset
@@ -41,9 +42,16 @@
 
 
 class L2SSException(HarmonyException):
-    """Base class for exceptions in the Harmony GDAL Adapter."""
-
+    """L2SS Exception class for custom error messages to see in harmony api calls."""
     def __init__(self, original_exception):
+        # Ensure we can extract traceback information
+        if original_exception.__traceback__ is None:
+            # Capture the current traceback if not already present
+            try:
+                raise original_exception
+            except type(original_exception):
+                original_exception.__traceback__ = sys.exc_info()[2]
+
         # Extract the last traceback entry (most recent call) for the error location
         tb = traceback.extract_tb(original_exception.__traceback__)[-1]
 
@@ -57,7 +65,11 @@ def __init__(self, original_exception):
         readable_message = (f"Error in file '{filename}', line {lineno}, in function '{funcname}': "
                             f"{error_msg}")
 
-        super().__init__(readable_message, 'nasa/harmony-gdal-adapter')
+        # Call the parent class constructor with the formatted message and category
+        super().__init__(readable_message, 'podaac/l2-subsetter')
+
+        # Store the original exception for potential further investigation
+        self.original_exception = original_exception
 
 
 def podaac_to_harmony_bbox(bbox: np.ndarray) -> Union[np.ndarray, float]: