Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Harmony message cut parameter to subset_params in service adapter #248

Merged
merged 10 commits into from
Apr 22, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Mar 22, 2024

Github Issue: #247

Description

Enable a Harmony message to specify the subsetter's cut parameter.

Overview of work done

This changes the service adapter so that it checks if extraArgs is present in the Harmony message, and if so the value of cut —  from the Harmony message's extraArgs — is passed along to the subset() function.

Overview of integration done

The integration tests were successful using SAMBAH service and TEMPO collection in local Harmony environment

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@danielfromearth danielfromearth added the enhancement New feature or request label Apr 16, 2024
@danielfromearth
Copy link
Collaborator Author

@jamesfwood, do you know how we can ensure that the integration tests on this feature branch PR use the recently updated, 0.19.0, Harmony schema?

@danielfromearth danielfromearth marked this pull request as ready for review April 19, 2024 14:34
@ank1m
Copy link

ank1m commented Apr 19, 2024

The integration tests were successful using SAMBAH service and TEMPO collection in local Harmony environment

image

@jamesfwood jamesfwood changed the base branch from develop to release/2.10.0 April 22, 2024 17:26
@jamesfwood jamesfwood changed the base branch from release/2.10.0 to develop April 22, 2024 17:26
@jamesfwood jamesfwood merged commit fb6e6f4 into develop Apr 22, 2024
2 checks passed
@jamesfwood jamesfwood deleted the feature/issue-247-cut-parameter-from-harmony branch April 22, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept a boolean from Harmony to set cut= parameter when run as part of service chain
3 participants