Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new-streaming first/last aggregations #20716

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 14, 2025

Only contains an AnyValue-based general implementation right now, will add more performant options later.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 279 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (84bd611) to head (a4086ba).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/reduce/first_last.rs 0.00% 148 Missing ⚠️
crates/polars-expr/src/reduce/mod.rs 0.00% 88 Missing ⚠️
crates/polars-expr/src/reduce/min_max.rs 0.00% 14 Missing ⚠️
crates/polars-expr/src/reduce/sum.rs 0.00% 9 Missing ⚠️
crates/polars-expr/src/reduce/len.rs 0.00% 7 Missing ⚠️
crates/polars-stream/src/nodes/reduce.rs 0.00% 5 Missing ⚠️
crates/polars-expr/src/reduce/convert.rs 0.00% 2 Missing ⚠️
crates/polars-expr/src/reduce/mean.rs 0.00% 2 Missing ⚠️
crates/polars-stream/src/nodes/group_by.rs 0.00% 2 Missing ⚠️
.../polars-stream/src/physical_plan/lower_group_by.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20716      +/-   ##
==========================================
- Coverage   79.92%   79.83%   -0.10%     
==========================================
  Files        1559     1560       +1     
  Lines      221170   221448     +278     
  Branches     2530     2530              
==========================================
+ Hits       176764   176786      +22     
- Misses      43824    44080     +256     
  Partials      582      582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -66,7 +66,7 @@ def test_streaming_group_by_types() -> None:
pl.col("bool").last().alias("bool_last"),
pl.col("bool").mean().alias("bool_mean"),
pl.col("bool").sum().alias("bool_sum"),
pl.col("date").sum().alias("date_sum"),
# pl.col("date").sum().alias("date_sum"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Collaborator Author

@orlp orlp Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritchie46 Yes, the summing dates doesn't really make any sense, and it's not supported on the eager engine either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, shouldn't we error during IR resolving then?

@ritchie46 ritchie46 merged commit e3216b4 into pola-rs:main Jan 15, 2025
28 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants