Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Simplify hive predicate handling in NEW_MULTIFILE #20730

Merged
merged 1 commit into from
Jan 16, 2025
Merged

refactor: Simplify hive predicate handling in NEW_MULTIFILE #20730

merged 1 commit into from
Jan 16, 2025
+72 −123

Conversation

coastalwhite
Copy link
Collaborator

Don't do a manipulation of the PhysicalExpr instead just supply the columns when evaulate happens.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 15, 2025
@ritchie46 ritchie46 merged commit cae6788 into pola-rs:main Jan 16, 2025
22 of 23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@coastalwhite coastalwhite

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coastalwhite @ritchie46 @c-peters