Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix flaky test #20751

Merged
merged 2 commits into from
Jan 16, 2025
Merged

refactor: Fix flaky test #20751

merged 2 commits into from
Jan 16, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jan 16, 2025

Fixes a flaky test due to a silly typo 🙈

@nameexhaustion nameexhaustion added the skip changelog Do not include in changelog label Jan 16, 2025
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 16, 2025
@nameexhaustion nameexhaustion marked this pull request as ready for review January 16, 2025 14:27
@nameexhaustion nameexhaustion changed the title refactor: Fix perf regression refactor: Fix flaky test Jan 16, 2025
@ritchie46 ritchie46 merged commit 28a45f2 into pola-rs:main Jan 16, 2025
29 checks passed
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.72%. Comparing base (ce9ad17) to head (14f631a).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20751      +/-   ##
==========================================
- Coverage   79.73%   79.72%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      221913   221910       -3     
  Branches     2530     2530              
==========================================
- Hits       176943   176928      -15     
- Misses      44388    44400      +12     
  Partials      582      582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars skip changelog Do not include in changelog
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants