Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace unreachable with polars_bail #20789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jqnatividad
Copy link
Contributor

as its actually reachable and causes a panic when attempting unsupported ops like INSERT, UPDATE, DELETE, etc.

as its actually reachable and causes a panic when attempting unsupported ops like INSERT, UPDATE, DELETE, etc.
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (d9f3e3d) to head (6a3796d).

Files with missing lines Patch % Lines
crates/polars-sql/src/context.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20789      +/-   ##
==========================================
- Coverage   79.78%   79.77%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      221982   221982              
  Branches     2531     2531              
==========================================
- Hits       177107   177097      -10     
- Misses      44293    44303      +10     
  Partials      582      582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Nice, could you add a test on the python side for this? E.g. testing you get the error you expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants