Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log out using cosmic-osd #1160

Merged
merged 1 commit into from
Jan 18, 2025
Merged

chore: log out using cosmic-osd #1160

merged 1 commit into from
Jan 18, 2025

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented Jan 17, 2025

No description provided.

@wash2 wash2 requested a review from Drakulix January 17, 2025 18:43
@Drakulix
Copy link
Member

Oh I though we simply leave the Terminate Action, but change the default keybindings to bind to a new SystemAction calling cosmic-osd. That way both variants exist for either DE-experiments that don't have cosmic-osd or users that rather want to bind Terminate.

@wash2 wash2 marked this pull request as draft January 17, 2025 23:59
@wash2
Copy link
Contributor Author

wash2 commented Jan 18, 2025

requires pop-os/cosmic-settings-daemon#66

@wash2
Copy link
Contributor Author

wash2 commented Jan 18, 2025

I'll undo the changes to Cargo.toml before merging too.

@wash2 wash2 marked this pull request as ready for review January 18, 2025 03:37
@mmstick mmstick merged commit b87049b into master Jan 18, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants