Check if running in NVIDIA graphics mode #42
Conversation
crawfxrd
changed the title
|
This is meant to fix #34, right? |
|
Yeah, I guess. I did it to stop the spam on oryp10. |
|
I can't dismiss the HiDPI notification, which is the same behavior I see while in NVIDIA graphics mode. |
|
Confirmed this gets the HiDPI Daemon running again on addw2 in Hybrid mode. Still runs in NVIDIA and Integrated modes too. I am seeing an issue in Hybrid mode that is not appearing in NVIDIA mode. An external LoDPI display (27" 1440p ViewSonic VP2771LED) always appears with 200% scaling, regardless of the mode that the daemon is in. In NVIDIA mode, the external display always shows at 100% scale. Correct behavior in NVIDIA mode (external display on the right):
Same config in Hybrid mode (external display still on the right, although it defaulted to above multiple times):
I can't compare the behavior to Integrated mode since addw2 requires NVIDIA for any of the external display ports. |
| else: | ||
| with open(lid_file_path, 'r') as lid_file: | ||
| if 'open' in lid_file.read(): | ||
| return True |
There was a problem hiding this comment.
Greatly appreciate the use of a ContextManager here, that file was never getting closed it looks like.
|
I have a Dell U2515H plugged in via HDMI. I see HiDPI overriding scaling to 200% on the eDP. And if I reboot with it plugged it, it thinks the external display is the default device. How does it behave if hidpi-daemon is uninstalled? |
Signed-off-by: Tim Crawford <[email protected]>
Just checking for the proprietary drivers is no longer sufficient, as they will be loaded in hybrid graphics mode but not be used for rendering the desktop. Rely on the `/etc/prime-discrete` file written by system76-power and gpu-manager to check which rendering mode is being used, falling back to checking the modules if it doesn't exist. Signed-off-by: Tim Crawford <[email protected]>
| @@ -1,3 +1,10 @@ | |||
| hidpi-daemon (18.04.7~~alpha) bionic; urgency=low | |||
There was a problem hiding this comment.
Should I change this to focal?
There was a problem hiding this comment.
Updating the version and codename might be a good idea depending on how much longer we believe we need to include this software.
Just checking for the proprietary drivers is no longer sufficient, as they will be loaded in hybrid graphics mode but not be used for rendering the desktop.
Rely on the
/etc/prime-discretefile written by system76-power and gpu-manager to check which rendering mode is being used, falling back to checking the modules if it doesn't exist.