Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if running in NVIDIA graphics mode #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions debian/changelog
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
hidpi-daemon (18.04.7~~alpha) bionic; urgency=low
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change this to focal?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the version and codename might be a good idea depending on how much longer we believe we need to include this software.


* Daily WIP for 18.04.7
* Fixed running in hybrid graphics mode

-- Tim Crawford <[email protected]> Fri, 02 Sep 2022 10:26:20 -0600

hidpi-daemon (18.04.6) bionic; urgency=low

* Update hidpidaemon2.py file to set gi require version
Expand Down
2 changes: 1 addition & 1 deletion hidpidaemon/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import logging


__version__ = '18.04.6'
__version__ = '18.04.7'

datadir = path.join(path.dirname(path.abspath(__file__)), 'data')
log = logging.getLogger(__name__)
Expand Down
27 changes: 18 additions & 9 deletions hidpidaemon/hidpidaemon2.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,14 +191,24 @@ def init_xlib(self):

self.displays_xml = self.get_displays_xml()

#Test for nvidia proprietary driver and nvidia-settings
# Check which GPU is used for rendering the desktop
def get_gpu_vendor(self):
if self.model in INTEL:
return 'intel'
modules = open('/proc/modules', 'r')
if 'nvidia ' in modules.read() and which('nvidia-settings') is not None:
return 'nvidia'
else:

# Check for system76-power/gpu-manager written file first
try:
with open('/etc/prime-discrete') as mode:
if mode.read().strip() == 'on':
return 'nvidia'
return 'intel'
except:
pass

# Fall back to checking loaded modules
with open('/proc/modules', 'r') as modules:
if 'nvidia ' in modules.read() and which('nvidia-settings') is not None:
return 'nvidia'
return 'intel'

def add_output_mode(self):
Expand Down Expand Up @@ -1046,10 +1056,9 @@ def get_internal_lid_state(self):
return True # No lids found: System may not be a laptop.
else:
lid_file_path = os.path.join('/', 'proc', 'acpi', 'button', 'lid', lid_dirs[0], 'state')
lid_file = open(lid_file_path, 'r')
if 'open' in lid_file.read():
return True
else:
with open(lid_file_path, 'r') as lid_file:
if 'open' in lid_file.read():
return True
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greatly appreciate the use of a ContextManager here, that file was never getting closed it looks like.

return False
except:
return True
Expand Down