-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if running in NVIDIA graphics mode #42
Open
crawfxrd
wants to merge
3
commits into
master
Choose a base branch
from
hybrid-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,10 @@ | ||
hidpi-daemon (18.04.7~~alpha) bionic; urgency=low | ||
|
||
* Daily WIP for 18.04.7 | ||
* Fixed running in hybrid graphics mode | ||
|
||
-- Tim Crawford <[email protected]> Fri, 02 Sep 2022 10:26:20 -0600 | ||
|
||
hidpi-daemon (18.04.6) bionic; urgency=low | ||
|
||
* Update hidpidaemon2.py file to set gi require version | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -191,14 +191,24 @@ def init_xlib(self): | |
|
||
self.displays_xml = self.get_displays_xml() | ||
|
||
#Test for nvidia proprietary driver and nvidia-settings | ||
# Check which GPU is used for rendering the desktop | ||
def get_gpu_vendor(self): | ||
if self.model in INTEL: | ||
return 'intel' | ||
modules = open('/proc/modules', 'r') | ||
if 'nvidia ' in modules.read() and which('nvidia-settings') is not None: | ||
return 'nvidia' | ||
else: | ||
|
||
# Check for system76-power/gpu-manager written file first | ||
try: | ||
with open('/etc/prime-discrete') as mode: | ||
if mode.read().strip() == 'on': | ||
return 'nvidia' | ||
return 'intel' | ||
except: | ||
pass | ||
|
||
# Fall back to checking loaded modules | ||
with open('/proc/modules', 'r') as modules: | ||
if 'nvidia ' in modules.read() and which('nvidia-settings') is not None: | ||
return 'nvidia' | ||
return 'intel' | ||
|
||
def add_output_mode(self): | ||
|
@@ -1046,10 +1056,9 @@ def get_internal_lid_state(self): | |
return True # No lids found: System may not be a laptop. | ||
else: | ||
lid_file_path = os.path.join('/', 'proc', 'acpi', 'button', 'lid', lid_dirs[0], 'state') | ||
lid_file = open(lid_file_path, 'r') | ||
if 'open' in lid_file.read(): | ||
return True | ||
else: | ||
with open(lid_file_path, 'r') as lid_file: | ||
if 'open' in lid_file.read(): | ||
return True | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Greatly appreciate the use of a ContextManager here, that file was never getting closed it looks like. |
||
return False | ||
except: | ||
return True | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I change this to
focal
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the version and codename might be a good idea depending on how much longer we believe we need to include this software.