fix: Don't enable rfd/async-std by default #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfd enables the 'async-std' feature by default, which causes a compile error when the 'tokio' feature is also enabled
mmstick
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfd enables the 'async-std' feature by default, which causes a compile error when the 'tokio' feature is also enabled. This PR changes the libcosmic dependencies so that rfd only has 'xdg-portal' enabled by default (rfd only imports ashpd conditionally based on compile target, so this feature should be fine to leave always enabled) and enables the 'async-std' feature of rfd if the libcosmic 'smol' feature is enabled.